Skip to content

[Backport] Minor Typo fix in AbstractFilter.php#20200

Closed
milindsingh wants to merge 1 commit intomagento:2.2-developfrom
milindsingh:2.2-develop-PR-port-20005
Closed

[Backport] Minor Typo fix in AbstractFilter.php#20200
milindsingh wants to merge 1 commit intomagento:2.2-developfrom
milindsingh:2.2-develop-PR-port-20005

Conversation

@milindsingh
Copy link
Copy Markdown
Member

@milindsingh milindsingh commented Jan 11, 2019

Original Pull Request

#20005

Description (*)

Minor Typo in comment

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Jan 11, 2019

Hi @milindsingh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Jan 11, 2019
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Jan 11, 2019

Hi @aleron75, thank you for the review.
ENGCOM-3829 has been created to process this Pull Request

@orlangur orlangur self-assigned this Jan 11, 2019
@orlangur
Copy link
Copy Markdown
Contributor

orlangur commented Jan 11, 2019

Unfortunately, we can't accept such Pull Requests to 2.2 release line, all code cleanup like typos, spelling mistakes, etc should be delivered to 2.3 release line. For more information, please, refer to Magento Code Contributions Guide.

@orlangur orlangur closed this Jan 11, 2019
@ghost
Copy link
Copy Markdown

ghost commented Jan 11, 2019

Hi @milindsingh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aleron75 aleron75 aleron75 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@orlangur orlangur

@aleron75 aleron75

Labels

Community Insider: Cedcommerce community-insider-contribution Component: Catalog Progress: reject Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.8

Development

Successfully merging this pull request may close these issues.

5 participants

@milindsingh @magento-engcom-team @orlangur @aleron75 @ajeetsinghcedcoss